Speed up importing pystac #1584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python import times are noticeable during interactive use of CLI applications, so push the (near) single-use imports into the functions where they are used so the import cost is paid when calling the functions instead of when starting the CLI to print the help or do some other unrelated action. Timings on top of stac-utils#1583 inside a Python:3.10-bookworm container. Before this change: $ uv run hyperfine --warmup 3 "python3 -c 'import pystac'" Benchmark 1: python3 -c 'import pystac' Time (mean ± σ): 67.2 ms ± 1.6 ms [User: 58.6 ms, System: 8.6 ms] Range (min … max): 62.5 ms … 69.9 ms 45 runs After this change: $ uv run hyperfine --warmup 3 "python3 -c 'import pystac'" Benchmark 1: python3 -c 'import pystac' Time (mean ± σ): 59.9 ms ± 1.5 ms [User: 52.0 ms, System: 7.8 ms] Range (min … max): 56.9 ms … 64.2 ms 48 runs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 92.38% 92.29% -0.09%
==========================================
Files 55 55
Lines 8375 8382 +7
Branches 965 965
==========================================
- Hits 7737 7736 -1
- Misses 453 461 +8
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gadomski
reviewed
Oct 6, 2025
I have seen this pattern a lot when using big imports like tensorflow, but I agree with you, I'm not sure if moving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Python import times are noticeable during
interactive use of CLI applications, so
push the (near) single-use imports into
the functions where they are used so
the import cost is paid when calling
the functions instead of when starting
the CLI to print the help or do some
other unrelated action.
Timings on top of #1583 inside
a Python:3.10-bookworm container.
Before this change:
$ uv run hyperfine --warmup 3 "python3 -c 'import pystac'" Benchmark 1: python3 -c 'import pystac'
Time (mean ± σ): 67.2 ms ± 1.6 ms [User: 58.6 ms, System: 8.6 ms]
Range (min … max): 62.5 ms … 69.9 ms 45 runs
After this change:
$ uv run hyperfine --warmup 3 "python3 -c 'import pystac'" Benchmark 1: python3 -c 'import pystac'
Time (mean ± σ): 59.9 ms ± 1.5 ms [User: 52.0 ms, System: 7.8 ms]
Range (min … max): 56.9 ms … 64.2 ms 48 runs
PR Checklist:
pre-commit run --all-files)pytest)